From 2df7c91926ed42861b17f96508f912cb8840927d Mon Sep 17 00:00:00 2001 From: chrisfu Date: Mon, 4 May 2026 01:44:51 -0700 Subject: [PATCH] fix(kong): SERVICE_NAMESPACE=default in conf/dev overlay caused kong to deploy to default ns MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit conf/dev/knoe.cfg had a stale SERVICE_NAMESPACE=default written by a prior TUI session. Also guard _service_namespace() so the value 'default' is never returned — it is never a valid service namespace and signals a stale generated config. Co-Authored-By: Claude Sonnet 4.6 --- conf/dev/knoe.cfg | 2 +- knoe/core/actions.py | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/conf/dev/knoe.cfg b/conf/dev/knoe.cfg index 3d51f8d..7412e94 100644 --- a/conf/dev/knoe.cfg +++ b/conf/dev/knoe.cfg @@ -5,5 +5,5 @@ CLUSTER_ENV = dev NAMESPACE = knoe-db DATABASE_NAMESPACE = knoe-db -SERVICE_NAMESPACE = default +SERVICE_NAMESPACE = knoe-system CLUSTER_NAME = knoe-db diff --git a/knoe/core/actions.py b/knoe/core/actions.py index 92b69e1..0770725 100644 --- a/knoe/core/actions.py +++ b/knoe/core/actions.py @@ -308,8 +308,12 @@ class KnoeInstaller: ) if ns.startswith("${") and ns.endswith("}"): ns = "" + if ns == "default": + ns = "" if not ns: ns = (os.environ.get("SERVICE_NAMESPACE") or "").strip() + if ns == "default": + ns = "" if ns: return ns