prole/tests/installer/test_cfg_save_refuses_mock_values.py

from __future__ import annotations

from pathlib import Path
from unittest.mock import MagicMock

import pytest

from knoe.ui.screens.cfg import ConfigMixin


class _DummyCfgAppWithMockVar(ConfigMixin):
    """Worst-case input: every widget var is a bare MagicMock.

    This is what happens when an interactive `./install.py -c conf/k3d.cfg`
    run launches the TUI in a context where Tk variables aren't real
    StringVars (headless env, partial mock setup, etc.).
    """

    def __init__(self, conf_dir: Path):
        self._conf_dir = conf_dir
        self._cfg_path_override = conf_dir / "knoe.cfg"
        self._mode = "k3d"
        self._resolved_service_namespace = "knoe-system"
        # Every var is a MagicMock — `var.get()` returns MagicMock,
        # `.strip()` returns MagicMock, `str(...)` returns a repr.
        for name in (
            "cluster_env",
            "selected_kubectx",
            "db_username",
            "db_password",
            "db_namespace",
            "cnpg_cluster_name",
            "db_host_port",
            "supabase_pv_node",
            "supabase_pv_base_dir",
            "gitops_node_selector",
            "argocd_node_selector",
            "k3s_server_url",
            "k3s_token",
            "prod_artifacts_path",
        ):
            setattr(self, name, MagicMock())

        self.knoe_cfg_data = {
            "Global": {},
            "Initialize Cluster": {},
            "Dev Cluster (k3d)": {},
            "Service Cluster (k3s)": {},
            "Prod Cluster (k8s)": {},
        }

    def _deployment_mode(self) -> str:
        return self._mode

    def _get_service_namespace(self) -> str:
        return self._resolved_service_namespace

    def _secret_cfg_value(self, *_args, **_kwargs):
        return ""

    def _save_ansible_knoe_vault(self, *_args, **_kwargs):
        return None

    def _sanitize_sections_for_cfg(self, sections: dict) -> dict:
        return sections

    def _sync_port_forward_mappings(self):
        return None

    def _collect_input_snapshot(self) -> dict:
        return {}


def test_save_knoe_cfg_refuses_non_string_widget_values(tmp_path, monkeypatch):
    """The save path must not serialize MagicMock (or any non-str) values
    into the cfg file. Either raise a clear TypeError, or skip the
    offending field. Silent str()-coercion-to-repr is forbidden.
    """
    import knoe.ui.screens.cfg as cfg_mod

    monkeypatch.setattr(cfg_mod.knoe_conf, "activate_environment", lambda *_a, **_k: None)

    app = _DummyCfgAppWithMockVar(tmp_path)
    cfg_path = tmp_path / "knoe.cfg"

    with pytest.raises((TypeError, ValueError)) as excinfo:
        app._save_knoe_cfg()

    # The error must name the offending field/var so the engineer can
    # diagnose without grepping mock-reprs out of files.
    assert "MagicMock" in str(excinfo.value) or "non-string" in str(excinfo.value).lower()

    # The cfg file must NOT contain any MagicMock string-reprs even if
    # save partially succeeded before raising.
    if cfg_path.exists():
        text = cfg_path.read_text()
        assert "<MagicMock" not in text, f"cfg leaked MagicMock repr:\n{text}"


class _Var:
    def __init__(self, value: str):
        self._value = value

    def get(self) -> str:
        return self._value


class _DummyCfgApp(ConfigMixin):
    """Real-string variant — save must succeed and produce a clean cfg."""

    def __init__(self, conf_dir: Path):
        self._conf_dir = conf_dir
        self._cfg_path_override = conf_dir / "knoe.cfg"
        self._mode = "k3d"
        self._resolved_service_namespace = "knoe-system"

        self.cluster_env = _Var("dev")
        self.selected_kubectx = _Var("k3d-knoe-system")
        self.db_username = _Var("knoe-db")
        self.db_password = _Var("secret")
        self.db_namespace = _Var("knoe-system")
        self.cnpg_cluster_name = _Var("knoe-db")
        self.db_host_port = _Var("5432")
        self.supabase_pv_node = _Var("")
        self.supabase_pv_base_dir = _Var("")
        self.gitops_node_selector = _Var("")
        self.argocd_node_selector = _Var("")
        self.k3s_server_url = _Var("")
        self.k3s_token = _Var("")
        self.prod_artifacts_path = _Var(str(conf_dir))
        self.service_namespace = _Var("knoe-system")

        self.knoe_cfg_data = {
            "Global": {},
            "Initialize Cluster": {},
            "Dev Cluster (k3d)": {},
            "Service Cluster (k3s)": {},
            "Prod Cluster (k8s)": {},
        }

    def _deployment_mode(self) -> str:
        return self._mode

    def _get_service_namespace(self) -> str:
        return self._resolved_service_namespace

    def _secret_cfg_value(self, _section, _key, value, *_args) -> str:
        return value

    def _save_ansible_knoe_vault(self, *_args, **_kwargs):
        return None

    def _sanitize_sections_for_cfg(self, sections: dict) -> dict:
        return sections

    def _sync_port_forward_mappings(self):
        return None

    def _collect_input_snapshot(self) -> dict:
        return {}


def test_save_knoe_cfg_real_strings_produce_clean_cfg(tmp_path, monkeypatch):
    """When all widget vars return real strings, save must succeed without
    any MagicMock reprs in the output file."""
    import knoe.ui.screens.cfg as cfg_mod

    monkeypatch.setattr(cfg_mod.knoe_conf, "activate_environment", lambda *_a, **_k: None)

    app = _DummyCfgApp(tmp_path)
    app._save_knoe_cfg()

    cfg_path = tmp_path / "knoe.cfg"
    assert cfg_path.exists(), "cfg file was not written"
    text = cfg_path.read_text()
    assert "<MagicMock" not in text
    assert "KUBECONTEXT" in text