chrisfu c0c43bcf6a fix(samba_dns): strip zone suffix correctly so internal A/CNAME/PTR records are created ... Forward A/CNAME and reverse PTR records reported changed=0 / ok but never resolved by short name on the Samba AD DC (myrddin.prole.org). Root cause was regex escaping inside YAML folded block scalars (">-"): unlike double-quoted scalars, block scalars do NOT process backslash escapes, so a pattern written as '\\.' reached Jinja as a literal backslash + any-char and never matched. Consequences: - regex_replace() never stripped the zone suffix, so records were created under their full FQDN (e.g. a record literally named "sg2428lp.prole.org" inside zone "prole.org"). `samba-tool dns query ... prole.org sg2428lp A` then returns WERR_DNS_ERROR_NAME_DOES_NOT_EXIST. - regex_findall() of existing values always returned [], so stale records were never pruned and idempotency only survived via RECORD_ALREADY_EXISTS. The leading/trailing whitespace from the folded scalar was a red herring: the command module's shlex tokenization collapses it, so a single-token name survived intact. The escaping was the actual defect. Fix: - Convert the templated set_fact expressions from ">-" block scalars to double-quoted single-line scalars (one consistent escaping convention, matching the already-working samba_target_zone line; also removes the stray whitespace). - Add an assertion that the computed record name is a clean, non-empty, whitespace-free token. - Add a post-apply verification re-query + assert that the expected value(s) are actually present, turning a silent no-op into a hard failure. Applies to roles/samba_dns (ensure_a.yml, ensure_cname.yml) and roles/samba_reverse_dns (ensure_ptr.yml). Verified end-to-end through ansible-playbook against a stateful fake samba-tool: correct short names (sg2428lp, git, @, registry), stale-value removal, internal.prole.org zone routing, idempotent re-runs (changed=0), and the verify-assert failing loudly when an add silently does not persist. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>		2026-06-10 00:32:00 -07:00
..
ensure_ptr.yml	fix(samba_dns): strip zone suffix correctly so internal A/CNAME/PTR records are created	2026-06-10 00:32:00 -07:00
main.yml	fix(samba_dns): use admin credentials instead of machine Kerberos (-P)	2026-05-14 23:15:13 -07:00