chrisfu/prole
1
0
Fork 0
mirror of https://github.com/dredx/prole.git synced 2026-09-24 15:04:31 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(kong): SERVICE_NAMESPACE=default in conf/dev overlay caused kong to deploy to default ns

Browse Source 
conf/dev/knoe.cfg had a stale SERVICE_NAMESPACE=default written by a prior TUI session.
Also guard _service_namespace() so the value 'default' is never returned — it is never
a valid service namespace and signals a stale generated config.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
chrisfu 2026-05-04 01:44:51 -07:00
parent c7871e2780
commit 2df7c91926
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
conf/dev/knoe.cfg
View File

@ -5,5 +5,5 @@
CLUSTER_ENV = dev CLUSTER_ENV = dev
NAMESPACE = knoe-db NAMESPACE = knoe-db
DATABASE_NAMESPACE = knoe-db DATABASE_NAMESPACE = knoe-db
SERVICE_NAMESPACE = default SERVICE_NAMESPACE = knoe-system
CLUSTER_NAME = knoe-db CLUSTER_NAME = knoe-db

4
knoe/core/actions.py
View File

@ -308,8 +308,12 @@ class KnoeInstaller:
) )
if ns.startswith("${") and ns.endswith("}"): if ns.startswith("${") and ns.endswith("}"):
ns = "" ns = ""
if ns == "default":
ns = ""
if not ns: if not ns:
ns = (os.environ.get("SERVICE_NAMESPACE") or "").strip() ns = (os.environ.get("SERVICE_NAMESPACE") or "").strip()
if ns == "default":
ns = ""
if ns: if ns:
return ns return ns